-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discard Message Output for Graylog2 1.3 #1688
Conversation
journal.markJournalOffsetCommitted(maxOffset); | ||
} | ||
|
||
public interface Factory extends MessageOutput.Factory<GelfOutput> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should rather be typed to DiscardMessageOutput
instead of GelfOutput
(same for the create
method).
I'll fix the return types in Thanks! |
Just to be clear, can we use this in a graylog server without any ES connected to it? Would it be something like a forwarder to another graylog server (that does the storage instead) ? |
Yes, that is one use case for it. Another one could be to run benchmarks having to have storage attached, although we do ship with a benchmark output that writes timings and counts to a CSV file. However if you don't want that you could use this output. |
Well how do we launch it? It's not present in graylog-web 1.3.3, I can only choose GELF Output and STDOUT Output. |
@razvanphp This message output is supposed to replace the default output (see https://github.com/Graylog2/graylog2-server/blob/1.3.3/graylog2-server/src/main/java/org/graylog2/Configuration.java#L131-L132) and not to be used as a stream output. |
I have butchered the Benchmark Output into something that simply discards messages - the rationale behind that is documented here :
https://medium.com/@henrikjohansen/graylog2-forwarder-nodes-5ec5e4f97e21#.yptnbrtv0
Please consider adding this to the 1.3 branch :)